Skip to main content

[BUGFIX] Build extbase attribute in UriBuilder fallback

With getRequest() in UriBuilder returning a
extbase Request in the fallback chain, we need
to have an extbase attribute when creating it.

Also avoid another call to $GLOBALS['TYPO3_REQUEST'].

Resolves: #99770
Related: #99650
Related: #99734
Related: #99757
Releases: main
Change-Id: Ic59394172a0834efbd2caada23cbf776322a8e11
Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/77648
Reviewed-by: Benni Mack <benni@typo3.org>
Tested-by: core-ci <typo3@b13.com>
Tested-by: Torben Hansen <derhansen@gmail.com>
Tested-by: Benni Mack <benni@typo3.org>
Reviewed-by: Torben Hansen <derhansen@gmail.com>


[BUGFIX] Build extbase attribute in UriBuilder fallback · TYPO3/typo3@4484b62

With getRequest() in UriBuilder returning a extbase Request in the fallback chain, we need to have an extbase attribute when creating it. Also avoid another call to $GLOBALS['TYPO3_REQUEST'...
GitHub
#99650 #99734 #99770 #99757

[TASK] Drop internal annotation from Extbase's UriBuilder->setRequest()

The setRequest() method is necessary to be called to set the current
request object when using the UriBuilder outside of an Extbase
controller or a view helper. The according changelog also states in
the migration section that the setRequest() method should be called.
So, we remove the internal annotation, so the method is now considered
as public API.

Related: #99650
Resolves: #99734
Releases: main
Change-Id: I45a2149d3215a7ea9abb2458da5eba922bed4cc7
Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/77630
Reviewed-by: Benni Mack <benni@typo3.org>
Tested-by: Torben Hansen <derhansen@gmail.com>
Reviewed-by: Torben Hansen <derhansen@gmail.com>
Tested-by: core-ci <typo3@b13.com>
Tested-by: Christian Kuhn <lolli@schwarzbu.ch>
Reviewed-by: Christian Kuhn <lolli@schwarzbu.ch>


[TASK] Drop internal annotation from Extbase's UriBuilder->setRequest() · TYPO3/typo3@41df9b9

The setRequest() method is necessary to be called to set the current request object when using the UriBuilder outside of an Extbase controller or a view helper. The according changelog also states ...
GitHub
#99650 #99734

[TASK] Use local Request Object in Extbase UriBuilder

The EXT:extbase UriBuilder already has a local instance
of the RequestInterface object, but relies in its method
`buildBackendUrl()` solely on $GLOBALS['TYPO3_REQUEST'].

This is now cleaned up, with a fallback on the global object
in case none has been given as a local instance. In this case,
a deprecation warning will be raised.

Resolves: #99650
Releases: main
Change-Id: Ib05a92c999e83e19cfde65a038439e3f571afba7
Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/77507
Tested-by: Stefan Bürk <stefan@buerk.tech>
Reviewed-by: Christian Kuhn <lolli@schwarzbu.ch>
Tested-by: Oliver Bartsch <bo@cedev.de>
Tested-by: Christian Kuhn <lolli@schwarzbu.ch>
Reviewed-by: Oliver Bartsch <bo@cedev.de>
Reviewed-by: Stefan Bürk <stefan@buerk.tech>
Tested-by: core-ci <typo3@b13.com>


[TASK] Use local Request Object in Extbase UriBuilder · TYPO3/typo3@c1c4986

The EXT:extbase UriBuilder already has a local instance of the RequestInterface object, but relies in its method `buildBackendUrl()` solely on $GLOBALS['TYPO3_REQUEST']. This is now cleane...
GitHub
#99650
⇧